From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 27/43] drm/i915: flush overlay regfile writes Date: Wed, 21 Dec 2011 21:41:33 +0100 Message-ID: <20111221204133.GG3827@phenom.ffwll.local> References: <1323867460-5486-1-git-send-email-daniel.vetter@ffwll.ch> <1323867460-5486-27-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 639109E733 for ; Wed, 21 Dec 2011 12:39:49 -0800 (PST) Received: by wibhq15 with SMTP id hq15so2709454wib.36 for ; Wed, 21 Dec 2011 12:39:48 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: Daniel Vetter , intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Wed, Dec 14, 2011 at 03:24:49PM +0000, Chris Wilson wrote: > On Wed, 14 Dec 2011 13:57:24 +0100, Daniel Vetter wrote: > > Better be paranoid. The wmb should flush the wc writes, and > > the chipset_flush hopefully flushes any mch buffers. There've been a > > few overlay hangs I've never really diagnosed, unfortunately all the > > reporters disappeared. > > At which point we should just put the darn wmb into i830_chipset_flush() > and make snark remarks about wbinvd. Iirc I've also had reports of nutty people trying the overlay on gen3. Maybe that got fixed with one of the domain tracking fixes, maybe not. Given that most users of this disappeared, I've thought adding some random lore here won't hurt and maybe it makes somebody happy ;-) -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48