From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 43/43] drm/i915: enable ppgtt
Date: Wed, 21 Dec 2011 21:46:08 +0100
Message-ID: <20111221204608.GH3827@phenom.ffwll.local>
References: <1323867460-5486-1-git-send-email-daniel.vetter@ffwll.ch>
	<1323867460-5486-43-git-send-email-daniel.vetter@ffwll.ch>
	<c55c5d$1cupvt@AZSMGA002.ch.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ww0-f43.google.com (mail-ww0-f43.google.com [74.125.82.43])
	by gabe.freedesktop.org (Postfix) with ESMTP id 9501C9E733
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 21 Dec 2011 12:44:23 -0800 (PST)
Received: by wgbds11 with SMTP id ds11so12342592wgb.12
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 21 Dec 2011 12:44:22 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <c55c5d$1cupvt@AZSMGA002.ch.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Dec 14, 2011 at 03:34:38PM +0000, Chris Wilson wrote:
> On Wed, 14 Dec 2011 13:57:40 +0100, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > v2: Don't try to enable ppgtt on pre-snb.
> > 
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
> > ---
> > +void i915_gem_init_ppgtt(struct drm_device *dev)
> > +{
> > +	drm_i915_private_t *dev_priv = dev->dev_private;
> > +	uint32_t pd_offset;
> > +	struct intel_ring_buffer *ring;
> > +	int i;
> > +
> > +	if (!HAS_ALIASING_PPGTT(dev))
> > +		return;
> I still think it is safer to use
>   if (dev_priv->mm.aliasing_ppgtt == NULL)
>     return;
> here
> 
> And pretty please can I module parameter to enable/disable ppgtt on
> boot.

I hope we can really avoid this. Working ppgtt is more or less required by
a bunch of things, and will at least result in strange suprises with
real per-process address spaces. Disabling the use of ppgtt with the
current code can be easily done by resetting the NON_SECURE flag in the
MI_START_BB cmd (or disabling all of it in the HAS_ALIASING_PPGTT macro).
This should be good enough to hammer out any outstanding issues with this.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48