From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [RFC] drm: implement DRM_IOCTL_MODE_SETROTATION Date: Thu, 5 Jan 2012 17:27:07 +0100 Message-ID: <20120105162707.GF3831@phenom.ffwll.local> References: <1325780183-23690-1-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1325780183-23690-1-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: przanoni@gmail.com Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni , dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Jan 05, 2012 at 02:16:23PM -0200, przanoni@gmail.com wrote: > From: Paulo Zanoni > > This ioctl is used to signal the drivers that the screen is rotated, > not to make the drivers rotate the screen. > - add a driver-specific "rotation_set" function > - implement Intel's rotation_set by setting the right values to the > PIPECONF registers. > > The idea is that when user-space does rotation, it can call this ioctl > to inform the Kernel that we have a rotation. This feature is needed > by the KVMr feature of VPro. > > Signed-off-by: Paulo Zanoni Quick comments before I dig into this: - Please post at least a link to the userspace patches, so that it's possible to check how this all fits together - Please separate the generic infrastructre in drm from the changes to support this in i915. I know, this is a rather small feature, but still. Cheers, Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48