From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wu Fengguang <fengguang.wu@intel.com>
Subject: Re: [PATCH] drm/i915: set AUD_CONFIG N_value_index for
	DisplayPort
Date: Mon, 16 Jan 2012 16:02:53 +0800
Message-ID: <20120116080252.GA18538@localhost>
References: <20120109131717.GA4713@localhost> <86y5tgx02g.fsf@sumi.keithp.com>
	<20120110054519.GA27257@localhost> <86ty404yhd.fsf@sumi.keithp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
	by gabe.freedesktop.org (Postfix) with ESMTP id 110B59E7A7
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 16 Jan 2012 00:02:56 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <86ty404yhd.fsf@sumi.keithp.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Keith Packard <keithp@keithp.com>
Cc: Takashi Iwai <tiwai@suse.de>, "intel-gfx@lists.freedesktop..." <intel-gfx@lists.freedesktop.org>, Michal Marek <mmarek@suse.com>, LKML <linux-kernel@vger.kernel.org>, Robert Lemaire <rlemaire@suse.com>
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Jan 12, 2012 at 09:33:34AM -0800, Keith Packard wrote:
> On Tue, 10 Jan 2012 13:45:19 +0800, Wu Fengguang <fengguang.wu@intel.com> wrote:
> 
> > @@ -5943,6 +5947,7 @@ static void ironlake_write_eld(struct dr
> >  	if (intel_pipe_has_type(crtc, INTEL_OUTPUT_DISPLAYPORT)) {
> >  		DRM_DEBUG_DRIVER("ELD: DisplayPort detected\n");
> >  		eld[5] |= (1 << 2);	/* Conn_Type, 0x1 = DisplayPort */
> > +		I915_WRITE(aud_config, AUD_CONFIG_N_VALUE_INDEX); /* 0x1 = DP */
> >  	}
> 
> Do we need to clear this bit in the HDMI case? Or do we just trust the
> BIOS to either leave this bit zero or set it correctly?

I tried booting

1) with HDMI monitor plugged
2) plug HDMI monitor after BIOS boot

In both cases, I get the same AUD_CONFIG values for the host/sink matrix

                RX-V1800        SONY TV
ivybridge       0x00000000      0x00000000
ironlake        0x00000000      0x00000000

HDMI audio is working fine in all cases. So I guess it's fine to leave
HDMI as (unconfigured) 0.

Thanks,
Fengguang