From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH-v2 0/3] drm/i915: interlaced mode support Date: Thu, 19 Jan 2012 11:28:35 +0100 Message-ID: <20120119102835.GA3779@phenom.ffwll.local> References: <20120118084207.612c7ab4@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ww0-f43.google.com (mail-ww0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id 0BC129E889 for ; Thu, 19 Jan 2012 02:28:41 -0800 (PST) Received: by wgbdr11 with SMTP id dr11so4533588wgb.12 for ; Thu, 19 Jan 2012 02:28:41 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: "Sun, Yi" Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org On Thu, Jan 19, 2012 at 09:51:16AM +0000, Sun, Yi wrote: > > > This patch set enables enables interlaced mode output on generation 3 > > > and above chipsets. > > > > > > History here: https://bugs.freedesktop.org/show_bug.cgi?id=11220 > > > > > > It has been tested on the following hardware: > > > * ASUS P5E-VM-HDMI (G35_G) and LG 32FS4D (VGA and SDVO connectors) > > > * Intel DQ45CB (Q45_G) and Sony GDM 5411 (VGA connector) > > > * Toshiba Portege R500 (I935_GM) and Sony GDM 5411 CRT (VGA connector) > > > > > > PATCH HISTORY > > > Version 1. Initial cut. > > > Version 2. Set timings for gen3 and ILK/SB chipsets. > > > Allow interlaced output on HDMI connector. > > > > > > Peter Ross (3): > > > drm/i915: specify vertical timings in frame units for interlaced > > > modes (gen3+) > > > drm/i915: allow interlaced mode output on the SDVO connector > > > drm/i915: allow interlaced mode output on the HDMI connector > > > > > > drivers/gpu/drm/i915/intel_display.c | 14 ++++++++++++++ > > > drivers/gpu/drm/i915/intel_hdmi.c | 2 +- > > > drivers/gpu/drm/i915/intel_sdvo.c | 2 +- > > > 3 files changed, 16 insertions(+), 2 deletions(-) > > > > Cool, this series looks good. > > > > Reviewed-by: Jesse Barnes > > > > Yi, can you give these patches a try with interlaced modes on SDVO and HDMI > > attached displays and reply with your tested-by? > > > > I tried the 3 patches on 3 machines, gm45(HDMI), g45(SDVO-HDMI) and a SandyBridge mobile(HDMI). > The patches work well on gm45 with HDMI and g45 with SDVO-HDMI card. I could reproduce the issue and fix it. > > But on the SandyBridge, it seems that the issue still exists. > > Tested-by: Sun Yi So I guess it works on pre-PCH_SPLIT machines, but not on later ones. Peter, on which machines have you tried this out? -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48