From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH] drm/i915: fixup assert_pipe to take the pipe A quirk into account Date: Tue, 24 Jan 2012 10:24:21 -0800 Message-ID: <20120124102421.14965c4f@jbarnes-desktop> References: <1327192608-18168-1-git-send-email-daniel.vetter@ffwll.ch> <864nvojquh.fsf@sumi.keithp.com> <20120123194027.GC5998@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1280545975==" Return-path: Received: from oproxy7-pub.bluehost.com (oproxy7-pub.bluehost.com [67.222.55.9]) by gabe.freedesktop.org (Postfix) with SMTP id D2529A022D for ; Tue, 24 Jan 2012 10:24:25 -0800 (PST) In-Reply-To: <20120123194027.GC5998@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org --===============1280545975== Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/Dmya6bh.=SrLlM2UGON.E7o"; protocol="application/pgp-signature" --Sig_/Dmya6bh.=SrLlM2UGON.E7o Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 23 Jan 2012 20:40:27 +0100 Daniel Vetter wrote: > On Sat, Jan 21, 2012 at 08:36:38PM -0800, Keith Packard wrote: > > On Sun, 22 Jan 2012 01:36:48 +0100, Daniel Vetter wrote: > > > This was completely spamming dmesg on my i855gm. > >=20 > > This comes from intel_disable_pll, which wants to turn the pll off, but > > if the pipe is still active, it won't be able to. This seems bad to me. >=20 > I honestly can't reconcile your comment with the code&patch. Afaics > - the pll disable code checks for the pipe a quirk and does an early exit > before mucking around with the hw and calling assert_pipe. > - assert_pipe only does a WARN and the patch only changes whether we hit > that WARN. All reg reads/writes should be unchanged. > - the backtrace I'm seeing goes through crtc_disable. Ah ok so it's coming from the new pipe disabled check Chris added. Patch looks fine... and reminds me to be puzzled about the pipe a force quirk on 855. :) --=20 Jesse Barnes, Intel Open Source Technology Center --Sig_/Dmya6bh.=SrLlM2UGON.E7o Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAEBAgAGBQJPHvdVAAoJEIEoDkX4Qk9hlXsP/iA2ZVpMXEJdE+a0D8q1xA5w AKGF7GC4W+dIfNPkIS0lMg6EbkyK9wZrjGwVs4x1vvnSU7DckeieKK9WQZEKfPse FT8l1Jl5bDupfC0ZTloz8CLa1lKBwjih2agEL1rsB6Jk7a3zPhSjT0YJFPG52C7X u8C6NYjM4CiFhbmD8Wti30VwFBCADHnd5JimV7QRK3mCo0UZawkL/w8UbACeK7r9 wzeSyIU3jdkioksHBLEAIw89PlVwchKVByxXLsaAF39Of8uacb9NiF+QqLPTTQa7 Pp1yNGzpB9wMp8/kcYmZ/WwiRUF4P3NKS+fV18KA2rx3uE9/KpNSdQy3LvoVLI3n 5U10LFvnYzU6H+C9KCcRE2zvmgrOEO/V7akZdvzhFZqYelqSFciHGmC5diuXk85G pjDObb1idKQLLu1HE5N247vjG4HOTJkbCh5VmkkFA548CCHoH3aVR+cVCppvMpZ0 rSVOXTIIYvtirv0SI2B6RsMib4Mee8ZmNPlXt7npwxB1qOjZnO73O4rmuDQ3ckiw 5sxIVvoZIlLUyCcyDSMEXRvymfxCsvkcSho8PG9NWllLbaEMxGsauUVYtyGooOjN EHWRSx3/2ZOIOdC/VHXfl/UVY70uTALkQmf4y3uOkrMNBjuyJVhIBKNk6M9lQ1FK MYtom7BDtqEc+aKjPmZj =QzKi -----END PGP SIGNATURE----- --Sig_/Dmya6bh.=SrLlM2UGON.E7o-- --===============1280545975== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1280545975==--