From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: fixup assert_pipe to take the
 pipe A quirk into account
Date: Tue, 24 Jan 2012 19:49:07 +0100
Message-ID: <20120124184907.GF3980@phenom.ffwll.local>
References: <1327192608-18168-1-git-send-email-daniel.vetter@ffwll.ch>
	<864nvojquh.fsf@sumi.keithp.com>
	<20120123194027.GC5998@phenom.ffwll.local>
	<20120124102421.14965c4f@jbarnes-desktop>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ww0-f41.google.com (mail-ww0-f41.google.com [74.125.82.41])
	by gabe.freedesktop.org (Postfix) with ESMTP id 9F7749EB23
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 24 Jan 2012 10:49:07 -0800 (PST)
Received: by wgbdt11 with SMTP id dt11so702972wgb.0
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 24 Jan 2012 10:49:06 -0800 (PST)
In-Reply-To: <20120124102421.14965c4f@jbarnes-desktop>
Content-Disposition: inline
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Jan 24, 2012 at 10:24:21AM -0800, Jesse Barnes wrote:
> On Mon, 23 Jan 2012 20:40:27 +0100
> Daniel Vetter <daniel@ffwll.ch> wrote:
> 
> > On Sat, Jan 21, 2012 at 08:36:38PM -0800, Keith Packard wrote:
> > > On Sun, 22 Jan 2012 01:36:48 +0100, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > > > This was completely spamming dmesg on my i855gm.
> > > 
> > > This comes from intel_disable_pll, which wants to turn the pll off, but
> > > if the pipe is still active, it won't be able to. This seems bad to me.
> > 
> > I honestly can't reconcile your comment with the code&patch. Afaics
> > - the pll disable code checks for the pipe a quirk and does an early exit
> >   before mucking around with the hw and calling assert_pipe.
> > - assert_pipe only does a WARN and the patch only changes whether we hit
> >   that WARN. All reg reads/writes should be unchanged.
> > - the backtrace I'm seeing goes through crtc_disable.
> 
> Ah ok so it's coming from the new pipe disabled check Chris added.
> Patch looks fine... and reminds me to be puzzled about the pipe a force
> quirk on 855. :)

Ok, I've queued this for next with an improved commit msg stating that
this was only shortly introduced in -next (plus citing the offending
commit).

Thanks, Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48