From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: fix up locking inconsistency around gem_do_init Date: Thu, 26 Jan 2012 14:45:17 +0100 Message-ID: <20120126134517.GJ3896@phenom.ffwll.local> References: <1327574471-5677-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 4F4BE9E7FA for ; Thu, 26 Jan 2012 05:45:17 -0800 (PST) Received: by wera10 with SMTP id a10so538599wer.36 for ; Thu, 26 Jan 2012 05:45:16 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: Daniel Vetter , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Thu, Jan 26, 2012 at 01:42:02PM +0000, Chris Wilson wrote: > On Thu, 26 Jan 2012 11:41:11 +0100, Daniel Vetter wrote: > > The locking in our setup and teardown paths is rather arbitrary, but > > generally we try to protect gem stuff with dev->struct_mutex. Further, > > the ums/gem ioctl to setup gem _does_ take the look. So fix up this > > benign inconsistency. > > It is completely arbitrary and only exists to keep lockdep and various > BUG_ON(mutex_lock) happy. From your reading, we would have a lockdep > warning with ums/gem? > > The extra little step towards consistency is likely to save a warning > later, so > Reviewed-by: Chris Wilson Actually no lockdep splat to be expected, because gem_do_init is _really_ simple. But maybe we'll extend the gtt_clear stuff in there to be more involved and this could indeed change. But currently the only reason for that change is to satisfy my ocd ;-) -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48