From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Separate fence pin counting from normal bind pin counting Date: Sun, 29 Jan 2012 18:25:15 +0100 Message-ID: <20120129172515.GJ4312@phenom.ffwll.local> References: <20111123123844.GD3864@phenom.ffwll.local> <1322053448-6303-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 5B18F9EFA2 for ; Sun, 29 Jan 2012 09:25:14 -0800 (PST) Received: by wera10 with SMTP id a10so3516825wer.36 for ; Sun, 29 Jan 2012 09:25:13 -0800 (PST) Content-Disposition: inline In-Reply-To: <1322053448-6303-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Nov 23, 2011 at 01:04:08PM +0000, Chris Wilson wrote: > In order to correctly account for reserving space in the GTT and fences > for a batch buffer, we need to independently track whether the fence is > pinned due to a fenced GPU access in the batch or whether the buffer is > pinned in the aperture. Currently we count the fenced as pinned if the > buffer has already been seen in the execbuffer. This leads to a false > accounting of available fence registers, causing frequent mass evictions. > Worse, if coupled with the change to make i915_gem_object_get_fence() > report EDADLK upon fence starvation, the batchbuffer can fail with only > one fence required... > > Fixes intel-gpu-tools/tests/gem_fenced_exec_thrash > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=38735 > Signed-off-by: Chris Wilson > Reviewed-by: Daniel Vetter > Tested-by: Paul Neumann > --- > > A minor change for v3, to introduce the symmetric intel_unpin_fb_obj in > order to try and make it Jesse-proof. Ok, let's give kudos where it's due: Queued for -next with a slight amend to resolve the functional conflict with Jesse's sprite stuff. Thanks for the patch. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48