From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/2] drm/i915: Record the in-flight requests at the time of a hang Date: Wed, 8 Feb 2012 23:33:22 +0100 Message-ID: <20120208223322.GD22687@phenom.ffwll.local> References: <20120208145425.GD5030@phenom.ffwll.local> <1328731768-28301-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id EC7149E7C8 for ; Wed, 8 Feb 2012 14:33:12 -0800 (PST) Received: by wera10 with SMTP id a10so903821wer.36 for ; Wed, 08 Feb 2012 14:33:11 -0800 (PST) Content-Disposition: inline In-Reply-To: <1328731768-28301-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Feb 08, 2012 at 08:09:27PM +0000, Chris Wilson wrote: > Being able to tally the list of outstanding requests with the sequence > of commands in the ringbuffer is often useful evidence with respect to > driver corruption. > > Signed-off-by: Chris Wilson I like this and I think we can nicely put some more robust request->batchbuffer_bo tracking on top of this instead of the current broken heuristics. Two bikeshed comments - consisten seqno pretty-printing in the debugfs file - some mention that you've gone ahead and refactored the per-ring stuff quite a bit might be good. It confused me quite a bit until I've noticed what you've done and found the actual change ... Cheers, Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48