From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Don't lock panel registers when downclocking Date: Mon, 13 Feb 2012 11:08:31 +0100 Message-ID: <20120213100831.GC5301@phenom.ffwll.local> References: <1328135490-382-1-git-send-email-seanpaul@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 35AD69E752 for ; Mon, 13 Feb 2012 02:08:17 -0800 (PST) Received: by wico1 with SMTP id o1so3864788wic.36 for ; Mon, 13 Feb 2012 02:08:16 -0800 (PST) Content-Disposition: inline In-Reply-To: <1328135490-382-1-git-send-email-seanpaul@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Sean Paul Cc: intel-gfx@lists.freedesktop.org, jglasgow@chromium.org, seanpaul@google.com List-Id: intel-gfx@lists.freedesktop.org On Wed, Feb 01, 2012 at 05:31:30PM -0500, Sean Paul wrote: > This patch removes the locking from the downclock routines since we are no > longer locking the registers at all. See ed10fca9 for the original commit > changing this philosophy. > > Signed-off-by: Sean Paul I've thought this was due to paranoia because we don't trust our own code and because we don't trust the bios to randomly lock this again. Without any reasons to the contrary, I'll prefer to keep this. Yours, Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48