From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915/lvds: Always use the presence pin
 for LVDS on PCH
Date: Wed, 15 Feb 2012 16:47:13 +0100
Message-ID: <20120215154713.GA26578@phenom.ffwll.local>
References: <1328780153-3945-1-git-send-email-chris@chris-wilson.co.uk>
	<86pqdoc4lc.fsf@sumi.keithp.com>
	<aefc95$34r1in@orsmga001.jf.intel.com>
	<86k43vdfx2.fsf@sumi.keithp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com
	[209.85.212.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id 025639E77F
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 15 Feb 2012 07:47:03 -0800 (PST)
Received: by wico1 with SMTP id o1so731840wic.36
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 15 Feb 2012 07:47:03 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <86k43vdfx2.fsf@sumi.keithp.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Keith Packard <keithp@keithp.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Feb 09, 2012 at 10:23:37AM -0800, Keith Packard wrote:
> <#part sign=pgpmime>
> On Thu, 09 Feb 2012 17:33:23 +0000, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > 
> > That code already existed in intel_lvds_init():
> >   if (HAS_PCH_SPLIT(dev)) {
> >      if (I915_READ(PCH_LVDS) & LVDS_DETECTED) == 0)
> >         return false
> >      ...
> >   }
> 
> Tricky. Do we have any idea how reliable this pin is? We've had such bad
> luck in the past...

It's imo guaranteed to blow up somewhere, but we already have the no_lvds
quirk infrastructure in place for that. Bug reporter confirmed that this
patch works for him, so I've decided to include this into the current
-next cycle to get feedback (and no_lvds quirk patches) as early as
possible.

Thanks for the patch and review.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48