From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: error_buffer->ring should be signed Date: Mon, 27 Feb 2012 18:15:08 +0100 Message-ID: <20120227171508.GF4866@phenom.ffwll.local> References: <20120216064004.GA23794@elgon.mountain> <1329386609-15885-1-git-send-email-daniel.vetter@ffwll.ch> <20120216111627.GM26353@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20120216111627.GM26353@mwanda> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Dan Carpenter Cc: Daniel Vetter , Intel Graphics Development , DRI Development List-Id: intel-gfx@lists.freedesktop.org On Thu, Feb 16, 2012 at 02:16:27PM +0300, Dan Carpenter wrote: > On Thu, Feb 16, 2012 at 11:03:29AM +0100, Daniel Vetter wrote: > > gcc seems to get uber-anal recently about these things. > > > > Sorry, I should have said that it's not a gcc warning, it's a > smatch thing. But also it's not uber-anal. It's the exact level of > anality which is required to make the == -1 test work. You can > compare unsigned int and longs to -1 and it works but for smaller > types it doesn't. I've picked this one here up for -next, thanks for your clarification (added to the commit message in). -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48