From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 1/2] drm/i915: Check VBIOS value for
 determining LVDS dual channel mode, too
Date: Tue, 20 Mar 2012 11:01:22 +0100
Message-ID: <20120320094114.GA3951@phenom.ffwll.local>
References: <1332155257-17649-1-git-send-email-tiwai@suse.de>
	<1332155257-17649-2-git-send-email-tiwai@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com
	[209.85.212.169])
	by gabe.freedesktop.org (Postfix) with ESMTP id 6C5419E7EE
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 20 Mar 2012 03:00:44 -0700 (PDT)
Received: by wibhm17 with SMTP id hm17so4082398wib.0
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 20 Mar 2012 03:00:43 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1332155257-17649-2-git-send-email-tiwai@suse.de>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Takashi Iwai <tiwai@suse.de>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Mon, Mar 19, 2012 at 12:07:36PM +0100, Takashi Iwai wrote:
> Currently i915 driver checks [PCH_]LVDS register bits to decide
> whether to set up the dual-link or the single-link mode.  This relies
> implicitly on that BIOS initializes the register properly at boot.
> However, BIOS doesn't initialize it always.  When the machine is
> booted with the closed lid, BIOS skips the LVDS reg initialization.
> This ends up in blank output on a machine with a dual-link LVDS when
> you open the lid after the boot.
> 
> This patch adds a workaround for that problem by checking the initial
> LVDS register value in VBT.
> 
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
> Reviewed-by: Adam Jackson <ajax@redhat.com>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>

If I understand Keith correctly he would like this to only get used when
the lid is closed and the panel is off. But I don't see that mention in
you change log nor can I find how it works in the code. Has this been lost
or am I confused?

Thanks, Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48