From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 25/25] drm/i915: don't write ring regs until they're set up Date: Wed, 21 Mar 2012 14:56:46 -0700 Message-ID: <20120321145646.3ef014c4@jbarnes-desktop> References: <1332359326-15051-1-git-send-email-jbarnes@virtuousgeek.org> <1332359326-15051-26-git-send-email-jbarnes@virtuousgeek.org> <20120321214641.GP9913@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1099295627==" Return-path: Received: from oproxy1-pub.bluehost.com (oproxy1-pub.bluehost.com [66.147.249.253]) by gabe.freedesktop.org (Postfix) with SMTP id 2EBDA9E761 for ; Wed, 21 Mar 2012 14:56:50 -0700 (PDT) In-Reply-To: <20120321214641.GP9913@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1099295627== Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/t4jOIchzUYHQyMCnzz.d6+6"; protocol="application/pgp-signature" --Sig_/t4jOIchzUYHQyMCnzz.d6+6 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 21 Mar 2012 22:46:41 +0100 Daniel Vetter wrote: > On Wed, Mar 21, 2012 at 12:48:46PM -0700, Jesse Barnes wrote: > > intel_clear_scanline_wait tries to clear ring wait conditions when we > > turn off pipes, to prevent hanging WAIT_EVENT and similar commands. But > > we call it early before rings have been setup during initialization and > > shouldn't touch the ring regs yet. > >=20 > > Signed-off-by: Jesse Barnes >=20 > Just a curious question: Does vlv not like this and blow up or is this > just something that poped up in register trace/code reviewing? Just something that popped up. No actual harm done afaict aside from writing some real low register address during init... --=20 Jesse Barnes, Intel Open Source Technology Center --Sig_/t4jOIchzUYHQyMCnzz.d6+6 Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJPak6eAAoJEIEoDkX4Qk9hWOYP/3DUT1MeeeMqAiYnvJTpaIl7 Y6BdURV5kdZkkwG3dDoeSRf+PjCjawmUgJcZQNVsIV/pQi9rYR4+C+2xB1pomDV6 66g3xDqAZzdSNKTE9x5or7/1mPryNPjPV+g8J/WGDBwMLL5HiYbyloejZy4Et7dv Dwmyo1Sz3rL1CQuGDC2PEnhuYJMAWcA9wq5WiCpFr4cT7yFquF/cPEhNrn2TTm0E /UhJTMKu5/QDKMqicaHs6+KXa0rT8+UH3yq+//LWbsXxzRU+MB/Mo3IT++d7hMIi wZS69aV+jm7Elq7wwOEMnfMVAzeHAJrpxkSIY2eml1nXqj8A/BOD2t+PRuHuDu75 ksLfiw9eaJZNbyHdG8+ldTYqjqbWcjK2IS6Vlb6L5S5RkCw4xNqKWqrU9s5WG5ht odJkj3ZEqAQuO+Nev17LaYlGsWKN+waYS/x8u6KGiUJp3jBApsjBDgnlrirlVnZD eiEHzfVzyGsRl05WibtOGfdCoSKE4HL/LlwCmzaYefJrUw/5OW6l4VxQnS9yV1rs Gd5OIosgbD5JrkkYOpPDPwUhsvrKUkHhK31RyWXet6kJu5lgsMSZnUopA81HtER8 9yH99mkUwrKPll9eVW/Dh+dPoG+5HTQ+eIcN9EOOZo1SzvbBos6M3na3eOq5Zdis 3srtjT3zhqAaHNdS+5a7 =DuyN -----END PGP SIGNATURE----- --Sig_/t4jOIchzUYHQyMCnzz.d6+6-- --===============1099295627== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1099295627==--