From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 04/25] drm/i915: Add basic support for parsing of VBT OEM Custom Block Date: Wed, 21 Mar 2012 18:30:11 -0700 Message-ID: <20120321183011.4329d7a0@bwidawsk.net> References: <1332359326-15051-1-git-send-email-jbarnes@virtuousgeek.org> <1332359326-15051-5-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com [184.106.247.128]) by gabe.freedesktop.org (Postfix) with ESMTP id BBB5C9E778 for ; Wed, 21 Mar 2012 18:30:23 -0700 (PDT) In-Reply-To: <1332359326-15051-5-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: Artem Bityutskiy , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, 21 Mar 2012 12:48:25 -0700 Jesse Barnes wrote: > From: Rohit Jain > > Added support for parsing the OEM Customizable Modes Block (#20) > in the VBIOS table. > > Signed-off-by: Rohit Jain > Reviewed-by: Shobhit Kumar > Reviewed-by: Vijay A. Purushothaman > Acked-by: Jesse Barnes > Reviewed-by: Eugeni Dodonov > Signed-off-by: Artem Bityutskiy > Signed-off-by: Jesse Barnes > --- I'll be honest, I haven't read through the whole series yet, but I really don't see the point of this patch, at least in the next few patches. Could we modify the commit to describe why we need this (or drop it)?