From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 04/25] drm/i915: Add basic support for parsing of VBT OEM Custom Block Date: Thu, 22 Mar 2012 08:45:32 -0700 Message-ID: <20120322084532.6595ea4d@jbarnes-desktop> References: <1332359326-15051-1-git-send-email-jbarnes@virtuousgeek.org> <1332359326-15051-5-git-send-email-jbarnes@virtuousgeek.org> <20120321183011.4329d7a0@bwidawsk.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2093149534==" Return-path: Received: from oproxy8-pub.bluehost.com (oproxy8-pub.bluehost.com [69.89.22.20]) by gabe.freedesktop.org (Postfix) with SMTP id CA8FF9EEDE for ; Thu, 22 Mar 2012 08:45:38 -0700 (PDT) In-Reply-To: <20120321183011.4329d7a0@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============2093149534== Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/WV8u1v8_ZL.L_5U/amo0bSH"; protocol="application/pgp-signature" --Sig_/WV8u1v8_ZL.L_5U/amo0bSH Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 21 Mar 2012 18:30:11 -0700 Ben Widawsky wrote: > On Wed, 21 Mar 2012 12:48:25 -0700 > Jesse Barnes wrote: >=20 > > From: Rohit Jain > >=20 > > Added support for parsing the OEM Customizable Modes Block (#20) > > in the VBIOS table. > >=20 > > Signed-off-by: Rohit Jain > > Reviewed-by: Shobhit Kumar > > Reviewed-by: Vijay A. Purushothaman > > Acked-by: Jesse Barnes > > Reviewed-by: Eugeni Dodonov > > Signed-off-by: Artem Bityutskiy > > Signed-off-by: Jesse Barnes > > --- >=20 > I'll be honest, I haven't read through the whole series yet, but I > really don't see the point of this patch, at least in the next few > patches. Could we modify the commit to describe why we need this (or > drop it)? This one is unrelated to VLV, it's just extra VBT gravy. Obviously it needs to stuff the mode info somewhere though... --=20 Jesse Barnes, Intel Open Source Technology Center --Sig_/WV8u1v8_ZL.L_5U/amo0bSH Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJPa0kcAAoJEIEoDkX4Qk9h9m0QAK6LGPkmYSVwP2y62YKDsthH 5yj+NLduR9AFHn82+zQ2AdIDPIqKMr2cFrpl/jAfhImQRc82IXxclq2NQgxBJrpN NYabE72dxSBObVtqPb085mlDbLXTFL44J9WPHNSkmYggKieUCmTpqQAxrKoLJoM8 cKxTHU8jf6j4bj2jqZeBeG7F/fnwWaK3pDyNMVlQc3QzHKSU87BgpZViixU34OQd EPd4/ULCwH4KkfMWnP4Ds0SZfvmjw3nPShMAxdH9VFejGhNmaUbsCa+UCLdeUqSF W4q2q3RxRTi7eXQGh8Vjiwilqj16RcPVI4HR80e1tTcksWMhHMHb4+sS2PuQyTSW FaO7lXJX5dluBB0yrL9tWhvgkNbNH4iOZ99rr7xgQ3bjD7dXzwpFbDSeM2op42+c g7qGiOPMZ02Ro0Zz9t+1SVZzNW4u/+5HxD4xfyT/TnYZev67yjrcAnKR73ok0/nG chV9DiTnheow8oqIzjVdqdW+0rPJ/WJn/SJLYqXo+PyvDN38jw5r7La6UIfntgiy 8FYdMZgtU6WVCpvhT6+cWIY23/4ovKyr42uZlQdLO3nfvuo9Njgcw/TCw5hm5ubQ 9M5RA3ir8ZvSr47E2NALywp//oqOWfRvhaFfNiFRNRSznMvn27UBzk4p/fTgG62u SQl8CPEaO1NA+IFMvnmD =WVP3 -----END PGP SIGNATURE----- --Sig_/WV8u1v8_ZL.L_5U/amo0bSH-- --===============2093149534== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============2093149534==--