From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 04/25] drm/i915: Add basic support for parsing of VBT OEM Custom Block Date: Thu, 22 Mar 2012 10:00:04 -0700 Message-ID: <20120322100004.38bf79ba@jbarnes-desktop> References: <1332359326-15051-1-git-send-email-jbarnes@virtuousgeek.org> <1332359326-15051-5-git-send-email-jbarnes@virtuousgeek.org> <20120321183011.4329d7a0@bwidawsk.net> <20120322084532.6595ea4d@jbarnes-desktop> <20120322091137.69100b9a@bwidawsk.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0782844265==" Return-path: Received: from oproxy1-pub.bluehost.com (oproxy1-pub.bluehost.com [66.147.249.253]) by gabe.freedesktop.org (Postfix) with SMTP id DDE409E8AF for ; Thu, 22 Mar 2012 10:00:12 -0700 (PDT) In-Reply-To: <20120322091137.69100b9a@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0782844265== Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/5v=3UyIqIao_V./QXg4AWip"; protocol="application/pgp-signature" --Sig_/5v=3UyIqIao_V./QXg4AWip Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Thu, 22 Mar 2012 09:11:37 -0700 Ben Widawsky wrote: > On Thu, 22 Mar 2012 08:45:32 -0700 > Jesse Barnes wrote: >=20 > > On Wed, 21 Mar 2012 18:30:11 -0700 > > Ben Widawsky wrote: > >=20 > > > On Wed, 21 Mar 2012 12:48:25 -0700 > > > Jesse Barnes wrote: > > >=20 > > > > From: Rohit Jain > > > >=20 > > > > Added support for parsing the OEM Customizable Modes Block (#20) > > > > in the VBIOS table. > > > >=20 > > > > Signed-off-by: Rohit Jain > > > > Reviewed-by: Shobhit Kumar > > > > Reviewed-by: Vijay A. Purushothaman > > > > Acked-by: Jesse Barnes > > > > Reviewed-by: Eugeni Dodonov > > > > Signed-off-by: Artem Bityutskiy > > > > Signed-off-by: Jesse Barnes > > > > --- > > >=20 > > > I'll be honest, I haven't read through the whole series yet, but I > > > really don't see the point of this patch, at least in the next few > > > patches. Could we modify the commit to describe why we need this (or > > > drop it)? > >=20 > > This one is unrelated to VLV, it's just extra VBT gravy. Obviously it > > needs to stuff the mode info somewhere though... > >=20 >=20 > THe HW can behave one in two ways, you read the info out and that is > required to advance the internal state machine to get to the next info > you care about. Or, you read the info out and nobody knows or cares. I > truly don't know how this HW works yet, but I'd say if it's the former > it should be added as a comment to the code. If it's the latter, we > should drop the patch. As I said, it doesn't belong in the VLV patchset. It has nothing to do with touch hw though; it's just a way for us to get any OEM custom modes out of the VBT. For example on a given platform the VBT panel data may have a certain timing, but an additional timing may also be preferred, which might be specified in this block. So we should parse it, and add it to the appropriate connector's mode list. This patch only does the parsing, but doesn't add it to the mode list, so isn't useful by itself. At any rate, I'll drop it from this series. --=20 Jesse Barnes, Intel Open Source Technology Center --Sig_/5v=3UyIqIao_V./QXg4AWip Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJPa1qUAAoJEIEoDkX4Qk9hUEUQAMmM7CXSgSU7oNc0A0VCmJhU 6/Ie7X5meXlmzXroHZc6sHMWgdNoETxN4FgULlZZNWArRya3Dx+HcfodxJcN6vjF vA+1IHCcgBOfOhivE2qy0jsOaxVoshIzYFaZc6prtdAnd4MA84uZr4PWHU98WHfa pmppAe7RkSTH0Dmrqd+71fzAIBPZif3WHb22HHWcDtSmxjezkmldmKtE8JwJ8N0R V6jmbvkNG+5dlnKC/vC4Vpf4Ae+0hPy4x7sRhDw3m81+Ha+Ehyz3YdXa+YLehBDH xUqdSqo8lW1QcUoY70nz7IDMqGvX4yrRNHVrvjZuZ/QmKmwcmK6JLet91RouOVtT 8rdMiYujJPH8CrZNnKBMYxy7nHk2yY2BqlEH+UI6bMD0goK5DBqI2zw5TuZpraHl c0V1mrvTdZoZfQKcwd8qsfPtbhnQKQVd2Xh/CV53mqjcvdalAvU5nMseZPjQL94K dtKHao4NdNiiuTdNOebzPhDKzN2mwy/CJgtDmUPrLBAlaCRMKctTuhGWEv6K6WE6 bo5uDCyGMmrMwVzVM+MwtHKeXIOc0fKGeVCaq6pSHisp3Yo67Qn/Ad6pR7LaxApS ZoVSUw6lI7ZnVlXWlvp/vNuFcQFmxGn8npl5dBjfqlvV/b5+timoo1Zhch5Dddw1 VSOC2UK0n71NIrvdeEDL =EcRZ -----END PGP SIGNATURE----- --Sig_/5v=3UyIqIao_V./QXg4AWip-- --===============0782844265== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0782844265==--