From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 23/37] drm/i915: do not set 6BPP dithering on haswell Date: Thu, 22 Mar 2012 11:16:43 +0100 Message-ID: <20120322101643.GF6195@phenom.ffwll.local> References: <1332378612-3814-1-git-send-email-eugeni.dodonov@intel.com> <1332378612-3814-24-git-send-email-eugeni.dodonov@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41]) by gabe.freedesktop.org (Postfix) with ESMTP id 1BC34A0D6E for ; Thu, 22 Mar 2012 03:15:59 -0700 (PDT) Received: by wgbds1 with SMTP id ds1so246327wgb.0 for ; Thu, 22 Mar 2012 03:15:59 -0700 (PDT) In-Reply-To: <1332378612-3814-24-git-send-email-eugeni.dodonov@intel.com> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Eugeni Dodonov Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Mar 21, 2012 at 10:09:58PM -0300, Eugeni Dodonov wrote: > We don't have those bits on Haswell anymore, so do not set them. > > Signed-off-by: Eugeni Dodonov Hm, how is 6bpp dithering supposed to work now, when e.g. a lame dp link can't handle more due to bandwidth issues? -Daniel > --- > drivers/gpu/drm/i915/intel_display.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index e056c32..24a0a6c 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -5335,9 +5335,10 @@ static int i9xx_crtc_mode_set(struct drm_crtc *crtc, > pipeconf &= ~(PIPECONF_BPP_MASK | PIPECONF_DITHER_EN); > if (is_dp) { > if (mode->private_flags & INTEL_MODE_DP_FORCE_6BPC) { > - pipeconf |= PIPECONF_BPP_6 | > - PIPECONF_DITHER_EN | > + pipeconf |= PIPECONF_DITHER_EN | > PIPECONF_DITHER_TYPE_SP; > + if (!IS_HASWELL(dev)) > + pipeconf |= PIPECONF_BPP_6; > } > } > > -- > 1.7.9.2 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48