From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 07/37] drm/i915: add DP_TP_CTL registers
Date: Thu, 22 Mar 2012 13:28:58 +0100
Message-ID: <20120322122858.GB7971@phenom.ffwll.local>
References: <1332378612-3814-1-git-send-email-eugeni.dodonov@intel.com>
	<1332378612-3814-8-git-send-email-eugeni.dodonov@intel.com>
	<c55c5d$2ck5cd@AZSMGA002.ch.intel.com>
	<CAC7Lmns00HR8eGVHaR6JGoMci_vUqspKFxL6T6quWUvD5S2QMg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com
	[209.85.212.169])
	by gabe.freedesktop.org (Postfix) with ESMTP id 6DD5DA0DC7
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 22 Mar 2012 05:28:14 -0700 (PDT)
Received: by wibhm17 with SMTP id hm17so557914wib.0
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 22 Mar 2012 05:28:13 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CAC7Lmns00HR8eGVHaR6JGoMci_vUqspKFxL6T6quWUvD5S2QMg@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Eugeni Dodonov <eugeni@dodonov.net>
Cc: intel-gfx@lists.freedesktop.org, Eugeni Dodonov <eugeni.dodonov@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Mar 22, 2012 at 09:18:32AM -0300, Eugeni Dodonov wrote:
> On Thu, Mar 22, 2012 at 07:43, Chris Wilson <chris@chris-wilson.co.uk>wrote:
> 
> > On Wed, 21 Mar 2012 22:09:42 -0300, Eugeni Dodonov <
> > eugeni.dodonov@intel.com> wrote:
> > > This is one set of those registers for each pipe.
> >
> Would these not benefit from a #define DP_TP_CTL(pipe)?
> >
> 
> Sorry, my typo went in - there is one set of those registers for each
> *port*. I defined DP_TP_CTL(pipe) for this (and all other DP_TP_* ones),
> but in the end I figured out that pipes need to be programmed independently
> from ports.

Hm, so maybe it's time to add an enum ports as Chris suggested? Or is that
stuff to different on the different platforms to make sense?
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48