From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/2] drm/i915: Remove fence pipelining infrastructure Date: Fri, 23 Mar 2012 20:18:37 +0100 Message-ID: <20120323191837.GH4087@phenom.ffwll.local> References: <1332429001-13725-1-git-send-email-chris@chris-wilson.co.uk> <1332429001-13725-2-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 1707B9E796 for ; Fri, 23 Mar 2012 12:17:52 -0700 (PDT) Received: by werp11 with SMTP id p11so3545635wer.36 for ; Fri, 23 Mar 2012 12:17:52 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1332429001-13725-2-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Mar 22, 2012 at 03:10:01PM +0000, Chris Wilson wrote: > I have failed to find a way to make this work without random GPU deaths, > so remove the ability to pipeline a fence update using the GPU. In the > process, we can refactor the code to improve the error handling and > avoid unnecessary modifications to our VMA if we do not need to update > the fence register. > > Signed-off-by: Chris Wilson Mea culpa, but I agree that it's better to reap this instead of letting it languish even longer as some dead code. For the patch itself, this does way too much. Imo the gem_write_fence rework and the reaping of the pipelining logic should be separate patches (maybe even more) - I don't quite see through this patch and follow where things move to. Maybe also add some more comments about the lifetime rules wrt obj->ring obj->last_rendering_seqno and obj->last_fenced_seqno. Also, if you have any ideas for crazy i-g-t tests, I think we should use this opportunity to fill some of the gapping wholes wrt fencing we have in our testuite. And to pardon dense me: What does VMA mean in this context? Cheers, Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48