From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/3] drm/i915: extract intel_enable_rc6() Date: Sun, 25 Mar 2012 14:10:59 +0200 Message-ID: <20120325121059.GA5909@phenom.ffwll.local> References: <1332641388-7688-1-git-send-email-ben@bwidawsk.net> <1332641388-7688-2-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 032B99E75A for ; Sun, 25 Mar 2012 05:10:18 -0700 (PDT) Received: by wibhj13 with SMTP id hj13so2696649wib.12 for ; Sun, 25 Mar 2012 05:10:18 -0700 (PDT) In-Reply-To: <1332641388-7688-2-git-send-email-ben@bwidawsk.net> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org, Eugeni Dodonov List-Id: intel-gfx@lists.freedesktop.org On Sat, Mar 24, 2012 at 07:09:45PM -0700, Ben Widawsky wrote: > nice to have elsewhere > > CC: Eugeni Dodonov > Signed-off-by: Ben Widawsky I was momentarily confused with this commit message, until I've noticed that you need this in the next patch (I've assumed Eugeni needs to for something). So please slightly elaborate on the reasons for this. Also I've wondered whether we shouldn't filter the individual rc6 levels? Or are all counters sane once you enable at least one of the rc6 levels? -Daniel > --- > drivers/gpu/drm/i915/i915_drv.h | 1 + > drivers/gpu/drm/i915/intel_display.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index bbbc1a4..22ab4db 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -1414,6 +1414,7 @@ extern void ironlake_enable_rc6(struct drm_device *dev); > extern void gen6_set_rps(struct drm_device *dev, u8 val); > extern void intel_detect_pch(struct drm_device *dev); > extern int intel_trans_dp_port_sel(struct drm_crtc *crtc); > +extern int intel_enable_rc6(const struct drm_device *dev); > > extern void __gen6_gt_force_wake_get(struct drm_i915_private *dev_priv); > extern void __gen6_gt_force_wake_mt_get(struct drm_i915_private *dev_priv); > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index ab62c96..efbf709 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -8235,7 +8235,7 @@ void intel_init_emon(struct drm_device *dev) > dev_priv->corr = (lcfuse & LCFUSE_HIV_MASK); > } > > -static int intel_enable_rc6(struct drm_device *dev) > +int intel_enable_rc6(const struct drm_device *dev) > { > /* > * Respect the kernel parameter if it is set > -- > 1.7.9.4 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48