From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 16/26] agp/intel: add ValleyView AGP driver Date: Mon, 26 Mar 2012 09:08:28 +0200 Message-ID: <20120326070828.GB4014@phenom.ffwll.local> References: <1332452348-8814-1-git-send-email-jbarnes@virtuousgeek.org> <1332452348-8814-17-git-send-email-jbarnes@virtuousgeek.org> <20120326021631.GC6534@seagal.kumite> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id 71D44A0261 for ; Mon, 26 Mar 2012 00:07:44 -0700 (PDT) Received: by wgbdr12 with SMTP id dr12so2859738wgb.12 for ; Mon, 26 Mar 2012 00:07:43 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20120326021631.GC6534@seagal.kumite> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Sun, Mar 25, 2012 at 07:16:31PM -0700, Ben Widawsky wrote: > I'm pretty torn about whether or not we actually want to use .gen=7 > (both here and in the other patch). But if it's what you think is best, > let's do it. gen here is only used in the intel-gtt code. I expect it's prette irrelevant (haven't checked though). > do you really want gen6_check_flags? or i830_check_flags? > FWIW, I have no clue why we even need check_flags() Backwards compat for tha fake agp interface. We don't use it and hence it's totally irrelevant. We really should reap all this crap for gen6+ at least. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48