From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH v2 1/3] drm/i915: add rc6 residency times to debugfs Date: Mon, 26 Mar 2012 09:49:42 -0700 Message-ID: <20120326094942.27e333d6@bwidawsk.net> References: <1332722012-4853-1-git-send-email-ben@bwidawsk.net> <20120326093413.GJ4014@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com [184.106.247.128]) by gabe.freedesktop.org (Postfix) with ESMTP id DE960A02C9 for ; Mon, 26 Mar 2012 09:51:10 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Eugeni Dodonov Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 26 Mar 2012 09:33:51 -0300 Eugeni Dodonov wrote: > On Mon, Mar 26, 2012 at 06:34, Daniel Vetter wrote: > > > On Sun, Mar 25, 2012 at 05:33:27PM -0700, Ben Widawsky wrote: > > > RC6 residency should be in intervals of 1.28us, and the counter > > > wraps. Here is an example using awk to get the various RC6 and > > > RC6+ residency times in seconds, since boot. > > > > > > cat /sys/kernel/debug/dri/0/i915_drpc_info | grep residency | > > > awk -F':' > > -F' ' '{print $5 * 1.28 / 1000000}' > > > > > > This is primarily for debug, and QA/application developers using > > > the sysfs interface looking for more insight. > > > > > > Untested on IVB. > > > > Tested on my ivb, seems to yield sane numbers for the default > > configuration (i.e. enable rc+rc6p, disable rc6pp). > > > > Yeah, it should work on IVB except for some strange behavior > sometimes (I noticed that on IVB we sometimes get into RC6 even if we > pass the i915_enable_rc6=0 parameter). I don't know if it is Bios > playing some tricks with us or something changed in the mailbox > communication, but no harm came from this so far. I'll see what is > going on there. > > But for the patch itself: > Reviewed-by: Eugeni Dodonov > > Nothing like new and shiny powertop power-saving options :). > Well as I said... at least on SNB it seems the RC6 value is never 0. But I suspect this isn't because we go into RC6, but rather just a uninitialized register value. Probably would be nice to follow up with the designers on this one.