From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH v2 1/3] drm/i915: add rc6 residency times to
 debugfs
Date: Mon, 26 Mar 2012 15:34:16 -0700
Message-ID: <20120326153416.73b5b9b3@bwidawsk.net>
References: <1332722012-4853-1-git-send-email-ben@bwidawsk.net>
	<20120326093413.GJ4014@phenom.ffwll.local>
	<CAC7LmnseF7muUqrV0=237kJW0TGzQYdaT5C4pzWCjaEPiwwNNw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com
	[184.106.247.128])
	by gabe.freedesktop.org (Postfix) with ESMTP id 959B09EEAB
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 26 Mar 2012 15:34:25 -0700 (PDT)
In-Reply-To: <CAC7LmnseF7muUqrV0=237kJW0TGzQYdaT5C4pzWCjaEPiwwNNw@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Eugeni Dodonov <eugeni@dodonov.net>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Mon, 26 Mar 2012 09:33:51 -0300
Eugeni Dodonov <eugeni@dodonov.net> wrote:

> On Mon, Mar 26, 2012 at 06:34, Daniel Vetter <daniel@ffwll.ch> wrote:
> 
> > On Sun, Mar 25, 2012 at 05:33:27PM -0700, Ben Widawsky wrote:
> > > RC6 residency should be in intervals of 1.28us, and the counter
> > > wraps. Here is an example using awk to get the various RC6 and
> > > RC6+ residency times in seconds, since boot.
> > >
> > > cat /sys/kernel/debug/dri/0/i915_drpc_info  | grep residency |
> > > awk -F':'
> > -F' '  '{print $5 * 1.28 / 1000000}'
> > >
> > > This is primarily for debug, and QA/application developers using
> > > the sysfs interface looking for more insight.
> > >
> > > Untested on IVB.
> >
> > Tested on my ivb, seems to yield sane numbers for the default
> > configuration (i.e. enable rc+rc6p, disable rc6pp).
> >
> 
> Yeah, it should work on IVB except for some strange behavior
> sometimes (I noticed that on IVB we sometimes get into RC6 even if we
> pass the i915_enable_rc6=0 parameter). I don't know if it is Bios
> playing some tricks with us or something changed in the mailbox
> communication, but no harm came from this so far. I'll see what is
> going on there.
> 
> But for the patch itself:
> Reviewed-by: Eugeni Dodonov <eugeni.dodonov@gmail.com>
> 
> Nothing like new and shiny powertop power-saving options :).
> 

I'd like to resubmit this patch with either %u or %x instead of the %d.
Can I still keep your r-b?