From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 3/3] tests: rc6 residency test Date: Tue, 27 Mar 2012 09:22:03 +0200 Message-ID: <20120327072203.GA4276@phenom.ffwll.local> References: <1332722012-4853-1-git-send-email-ben@bwidawsk.net> <1332722012-4853-6-git-send-email-ben@bwidawsk.net> <20120326093713.GK4014@phenom.ffwll.local> <20120326094055.GL4014@phenom.ffwll.local> <20120326145435.7a296690@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id 870C59E7BB for ; Tue, 27 Mar 2012 00:21:24 -0700 (PDT) Received: by wgbdr12 with SMTP id dr12so3631596wgb.12 for ; Tue, 27 Mar 2012 00:21:23 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20120326145435.7a296690@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Mar 26, 2012 at 02:54:35PM -0700, Ben Widawsky wrote: > On Mon, 26 Mar 2012 11:40:55 +0200 > Daniel Vetter wrote: > > > On Mon, Mar 26, 2012 at 11:37:13AM +0200, Daniel Vetter wrote: > > > On Sun, Mar 25, 2012 at 05:33:32PM -0700, Ben Widawsky wrote: > > > > This is meant to test the sysfs entry for showing rc6 residency in > > > > milliseconds. Remember, sysfs is a permanent interface. > > > > > > > > v2: use new get_card interface to try "all" devices > > > > check rc6p and rc6pp in addition to rc6 > > > > > > > > Signed-off-by: Ben Widawsky > > > > > > You're still missing the drm_quiescent_gpu(fd) call before doing the > > > residency measurements. Which makes this test fail reliably in the > > > i-g-t testsuite because the gpu is still busy from previous tests. > > > Please run new tests also in the context of the full testuite to > > > catch such issues. > > > > Actually the quiescent seems to be there, so I don't know what's > > going on. -Daniel > > I ran this on IVB, both individual and with make test (Ken's machine), > and it passed. Ok, I'll digg into this and try to find out why it fails on my ivb. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48