From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: RFC: i915 arch changes to better support new chipsets Date: Wed, 28 Mar 2012 12:46:16 -0700 Message-ID: <20120328124616.21c5fa5a@jbarnes-desktop> References: <20120320111357.56093868@jbarnes-desktop> <20120320184304.GC27231@phenom.ffwll.local> <20120320131347.10427988@jbarnes-desktop> <20120321134121.6eef8b74@jbarnes-desktop> <871uocldra.fsf@eliezer.anholt.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0869256930==" Return-path: Received: from oproxy8-pub.bluehost.com (oproxy8-pub.bluehost.com [69.89.22.20]) by gabe.freedesktop.org (Postfix) with SMTP id 9870FA0E30 for ; Wed, 28 Mar 2012 12:46:21 -0700 (PDT) In-Reply-To: <871uocldra.fsf@eliezer.anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Eric Anholt Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0869256930== Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/b5cZ1jlYiYYI1/RPE27cRqu"; protocol="application/pgp-signature" --Sig_/b5cZ1jlYiYYI1/RPE27cRqu Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 28 Mar 2012 12:35:53 -0700 Eric Anholt wrote: > On Wed, 21 Mar 2012 13:41:21 -0700, Jesse Barnes wrote: > > On Tue, 20 Mar 2012 13:13:47 -0700 > > Jesse Barnes wrote: > > > > > I'm open to suggestions on how to fix i915_reg.h; it's becoming q= uite a > > > > > beast. Our goal to be to make it easy to add new definitions whi= le > > > > > also making it easy to not accidentally use old an incorrect > > > > > definitions on a new platform. > > > >=20 > > > > Close your eyes and just keep on adding gunk. Imo i915_reg.h is pre= tty > > > > much a write-once file, and cscope can still keep up with the defin= itions. > > > > So not a pain point for me. > >=20 > > Oh I forgot the most important thing here: how many f*cking places do > > we need to add PCI IDs??!! > >=20 > > I'd really really like to see i915_reg.h shared to libdrm and used > > directly by intel-gpu-tools and Mesa if at all possible, whether we > > split it or not. The IS_* and HAS_* macros should be in there as well, > > with the PCI IDs, then we can just add this stuff in one place... >=20 > So, I was thinking about this, but the problem I see is that if we > settle on the PCI ID/gen-number identifier being in libdrm, then some > distro pulls a new libdrm with hsw bits, and ships the rest of old > userland that happily initializes and spits ivb packets at it. >=20 > I guess we could have the gen-number stuff be a union of > IS_IVB()/IS_HSW()/IS_VLV(), and switch chipset probing to using each of > those instead of just gen >=3D 4. >=20 > Does this sound sane? Yeah that might be better anyway, at least for the kernel where the IS_GEN stuff is getting more and more overloaded and I'd like to move away from it in some places. So if you're ok with it, that sounds like a good approach. --=20 Jesse Barnes, Intel Open Source Technology Center --Sig_/b5cZ1jlYiYYI1/RPE27cRqu Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJPc2qJAAoJEIEoDkX4Qk9hysUP/04uY5lfNNNYwvfDwJr1QK3a BpGdQrlcy8RmJtK3FuCd5WoZ1gCq5wdUROU5AJwBdd3JFr21G8JYARhZILZJ1sHc wgFJpsceaLvKzJ1vAiDYQjiUtspefHzcXw8thEkYhd4S8yCaxpvrLdqErWjZbl+A EZJBAYyiCQStZDgkW5DOcYZluoLRkuPBr38y9lQ5NqQQq7EgA+jf/J9fQ8j7J+ib EaPOvwcCGuSTVwGgxsbWYuaSXYB1Kl0JeaqkgqR2s1RYBHpe6p326JeVWXqsP+Xa QN5i9STnQtRUlM006c1PXDodNIOC3HJlYbSmELNQLEXafMOmIAxZnTh4mINq8kQ+ 2olSZ28g8WyN2TbPgvoYz67LirdkBa0IWEADNg+esss7bsi8U9x3Yg+mzXcUcB6g nZ47wGYCLc4EtZpBfCteFJMjTYOwfc+iftRczssNE9UiGQUS4wDsEXTLS1OSI1FP uKPfIDo/Bk/4S3ud3s9aDse2oNcbJkmHZ/GfohrvvySdyh7ToQBImY6WPuhlzVp5 pZFHNjtaBsMHeq9YA/2CPPJcRpPBMzDQcTUr3MObdTzQBy64wdqDpiNZsbw1rIIy R3FytuzXqqXztLNxXgbIqytTuLLgu6pmIdzM8DstFilw4y626JapMrh11ipwzYNj CgUNMSqPpG64BfHp8Kev =veNW -----END PGP SIGNATURE----- --Sig_/b5cZ1jlYiYYI1/RPE27cRqu-- --===============0869256930== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0869256930==--