From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 3/3] drm/i915: extract gt interrupt handler Date: Fri, 30 Mar 2012 11:28:40 -0700 Message-ID: <20120330112840.7d6b7721@jbarnes-desktop> References: <1333131875-24458-1-git-send-email-daniel.vetter@ffwll.ch> <1333131875-24458-3-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0569128861==" Return-path: Received: from oproxy7-pub.bluehost.com (oproxy7-pub.bluehost.com [67.222.55.9]) by gabe.freedesktop.org (Postfix) with SMTP id 70F189ED98 for ; Fri, 30 Mar 2012 11:28:46 -0700 (PDT) In-Reply-To: <1333131875-24458-3-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org --===============0569128861== Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/7KeiyrEAFo1GCrplKK_Ss=F"; protocol="application/pgp-signature" --Sig_/7KeiyrEAFo1GCrplKK_Ss=F Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 30 Mar 2012 20:24:35 +0200 Daniel Vetter wrote: > vlv, ivb and snb all share the gen6+ gt irq handling. 3 copies of the > same stuff is a bit much, so extract it into a little helper. >=20 > Now ilk has a different gt irq handling than snb, but shares the same > irq handler (due to the similar display block). So also extract the > ilk gt irq handling to clearly separate these two things. >=20 > Nice side effect of this is that we can complete Ben Widawsky's gen6+ > irq bit #define cleanup and call the render irq also with the GEN6 > alias. Beforehand that code was shared with ilk, and neither option > really made much sense. >=20 > As a bonus this enables the error interrupt handling lifted from the > vlv code on snb and ivb, too. >=20 > Signed-Off-by: Daniel Vetter Nice cleanup. Though I don't really like the IS_GEN5 branch in ironlake_irq_handler... might be nicer to just bite the bullet and have a mostly duplicate snb irq handler. Reviewed-by: Jesse Barnes --=20 Jesse Barnes, Intel Open Source Technology Center --Sig_/7KeiyrEAFo1GCrplKK_Ss=F Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJPdftYAAoJEIEoDkX4Qk9hyYMP/0ee891glD4UPaDK7o3b9gs6 Msd7jr9ObrwLAlEJIKMeobU/ao2MuMU//yV6Oy0QE72ZtdPgwkD1l51Vxlp7v9Tg y+kVVVqh3CSUW4iOOTSMpqUSLZFVN/ezGwwiN7tcjGd4wJRzoPuMSjCMaJtoSmp0 S/N0Go0B0snaNOrWOAak+zd9t7Xcf10+NcqNjy6DB9KLXF3C7548vsdzdSZ2OGTd zPnxEpW7YQL3EGyEB8wu6KoewTeZVbWYLbBmxFs4eiLadBYGDbHC2ntPyCG1UBcO 6J3AYDXbwsejjOs2CWD+GoKGiDuqIh8+nlgCkqD99GLi2enLikk9RhrWBz0paZAm KyudawNQtmYVvfjyO1gPfVG0W36vJw1S6ke/V+l3T7M02SRiRhkkm8Gq5DwRFLAL L9ZgLgrHveBWpvtGsTs2k2VYQF1M7wkuf6dKmBHlCAGYFvMd/MPcqYMtXmr//dDp Gs3Cj3Rd4d5NAONIFUpBk6hYQcS+AMpQ8x8XIvZknrqSYengXkOiEyc9+7ECUR0I Z32Vt7TkbNUEXAzKJaoAGN01eiOlBONOiA0Gxs9E00EbwODyxApF6RB4STtlaZ0q vzivIeqe1EuaaKmJTuzrnPpXJgE2nYvolclS8KZv0Y06qzcGYyGBOzE4GHwgSDD4 6K2+8EhzWlOGKrWVa0gO =6y6v -----END PGP SIGNATURE----- --Sig_/7KeiyrEAFo1GCrplKK_Ss=F-- --===============0569128861== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0569128861==--