From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 3/3] drm/i915: extract gt interrupt handler
Date: Sat, 31 Mar 2012 11:55:26 +0200
Message-ID: <20120331095526.GC4158@phenom.ffwll.local>
References: <1333131875-24458-1-git-send-email-daniel.vetter@ffwll.ch>
	<1333131875-24458-3-git-send-email-daniel.vetter@ffwll.ch>
	<20120330112840.7d6b7721@jbarnes-desktop>
	<20120330213127.160c4df0@bwidawsk.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-we0-f177.google.com (mail-we0-f177.google.com
	[74.125.82.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id AA1749E76A
	for <intel-gfx@lists.freedesktop.org>;
	Sat, 31 Mar 2012 02:54:43 -0700 (PDT)
Received: by werp11 with SMTP id p11so982735wer.36
	for <intel-gfx@lists.freedesktop.org>;
	Sat, 31 Mar 2012 02:54:42 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20120330213127.160c4df0@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Ben Widawsky <ben@bwidawsk.net>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Mar 30, 2012 at 09:31:27PM -0700, Ben Widawsky wrote:
> On Fri, 30 Mar 2012 11:28:40 -0700
> Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> 
> > On Fri, 30 Mar 2012 20:24:35 +0200
> > Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > 
> > > vlv, ivb and snb all share the gen6+ gt irq handling. 3 copies of
> > > the same stuff is a bit much, so extract it into a little helper.
> > > 
> > > Now ilk has a different gt irq handling than snb, but shares the
> > > same irq handler (due to the similar display block). So also
> > > extract the ilk gt irq handling to clearly separate these two
> > > things.
> > > 
> > > Nice side effect of this is that we can complete Ben Widawsky's
> > > gen6+ irq bit #define cleanup and call the render irq also with the
> > > GEN6 alias. Beforehand that code was shared with ilk, and neither
> > > option really made much sense.
> > > 
> > > As a bonus this enables the error interrupt handling lifted from the
> > > vlv code on snb and ivb, too.
> > > 
> > > Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > 
> > Nice cleanup.  Though I don't really like the IS_GEN5 branch in
> > ironlake_irq_handler... might be nicer to just bite the bullet and
> > have a mostly duplicate snb irq handler.
> > 
> > Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> > 
> 
> I agree with Jesse. Bite the bullet, you're already +LOC (see below),
> may as well give it a nice clean split.
> 
> Personally, I'd like to give you crap about the fact that your
> "cleanup" had a +LOC, which came up recently regarding my ILK
> context stuff.
> 
> Antagonized-by: Ben Widawsky <ben@bwidawsk.net>

Ok, I've picked these 3 patches up for -next, with Jesse's r-b extended to
all three (discussed quickyl on irc). Thanks for the review.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48