From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: IS_GEN6 && IS_GEN7 - is unpossible
Date: Mon, 9 Apr 2012 18:02:11 +0200
Message-ID: <20120409160211.GA4813@phenom.ffwll.local>
References: <1333830435-4424-1-git-send-email-ben@bwidawsk.net>
	<60a83a21-3cdd-4005-9f0c-ede909955bef@email.android.com>
	<20120407135811.2ff0d99d@bwidawsk.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-we0-f177.google.com (mail-we0-f177.google.com
	[74.125.82.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id 80A569E74E
	for <intel-gfx@lists.freedesktop.org>;
	Mon,  9 Apr 2012 09:01:49 -0700 (PDT)
Received: by werp11 with SMTP id p11so3293909wer.36
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 09 Apr 2012 09:01:48 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20120407135811.2ff0d99d@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org, Ben Widawsky <benjamin.widawsky@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Sat, Apr 07, 2012 at 01:58:11PM -0700, Ben Widawsky wrote:
> On Sat, 07 Apr 2012 13:48:30 -0700
> Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> 
> > Ben Widawsky <ben@bwidawsk.net> wrote:
> > 
> > >Imagine my surprise when tracking something down, I bisected to a VLV
> > >commit.
> > >
> > >CC: Jesse Barnes <jbarnes@virtuousgeek.org>
> > >Signed-off-by: Ben Widawsky <benjamin.widawsky@intel.com>
> > >---
> > > drivers/gpu/drm/i915/intel_display.c |    2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > >diff --git a/drivers/gpu/drm/i915/intel_display.c
> > >b/drivers/gpu/drm/i915/intel_display.c
> > >index 3abebb5..2ce1763 100644
> > >--- a/drivers/gpu/drm/i915/intel_display.c
> > >+++ b/drivers/gpu/drm/i915/intel_display.c
> > >@@ -9537,7 +9537,7 @@ void intel_modeset_init(struct drm_device *dev)
> > > 		intel_init_emon(dev);
> > > 	}
> > > 
> > >-	if ((IS_GEN6(dev) && IS_GEN7(dev)) && !IS_VALLEYVIEW(dev)) {
> > >+	if ((IS_GEN6(dev) || IS_GEN7(dev)) && !IS_VALLEYVIEW(dev)) {
> > > 		gen6_enable_rps(dev_priv);
> > > 		gen6_update_ring_freq(dev_priv);
> > > 	}
> > >-- 
> > >1.7.10
> > 
> > Daniel caught that one too, maybe he hasn't pushed the fix? 
> 
> Seems it hasn't been pushed, and I missed the exchange about the issue.
> As long as it's known already...`

Oh dear, how totally do I suck. And with rc6 disabled by accident on
snb&ivb the QA testing cycle is rather pointless, too.

I'll rip out the broken patch, rebase -testing and -next and ask QA to
re-run any gpu tests. I think modesetting tests shouldn't be affected by
rc6.

Ben, thanks for catching this screw-up.

Yours, Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48