From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 12/14] drm/i915: consolidate ring->flush a
	bit
Date: Fri, 13 Apr 2012 11:03:49 +0200
Message-ID: <20120413090349.GB4525@phenom.ffwll.local>
References: <1334175179-1514-1-git-send-email-daniel.vetter@ffwll.ch>
	<1334175179-1514-13-git-send-email-daniel.vetter@ffwll.ch>
	<20120412175445.08984215@bwidawsk.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-we0-f177.google.com (mail-we0-f177.google.com
	[74.125.82.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id EC5F99E7F4
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 13 Apr 2012 02:02:56 -0700 (PDT)
Received: by werp11 with SMTP id p11so2170940wer.36
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 13 Apr 2012 02:02:56 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20120412175445.08984215@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Ben Widawsky <ben@bwidawsk.net>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Apr 12, 2012 at 05:54:45PM -0700, Ben Widawsky wrote:
> On Wed, 11 Apr 2012 22:12:57 +0200
> Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> 
> > They're indentical, so just kill one. Also give the other a prefix to
> > distinguish it from the gen6+ functions - this add_request function is
> > not really generic code.
> > 
> > Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> The subject appears to indicate that you're consolidating ring->flush,
> but I think you meant add_request.

Oops, I'll fix this up when applying, thanks for catching this.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48