From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 4/5] drm/i915: Always flush tiling changes before accessing through the GTT Date: Sat, 14 Apr 2012 23:54:52 +0200 Message-ID: <20120414215452.GC4215@phenom.ffwll.local> References: <1334393751-8921-1-git-send-email-chris@chris-wilson.co.uk> <1334393751-8921-4-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by gabe.freedesktop.org (Postfix) with ESMTP id 13113A1146 for ; Sat, 14 Apr 2012 14:53:57 -0700 (PDT) Received: by wibhj13 with SMTP id hj13so5820492wib.12 for ; Sat, 14 Apr 2012 14:53:57 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1334393751-8921-4-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Sat, Apr 14, 2012 at 09:55:50AM +0100, Chris Wilson wrote: > As we defer updating the fence register from set-tiling to the point of > use, we need to declare every access through the GTT as either fenced or > unfenced. > > This patches fixes up a couple of freshly introduced GTT accesses which > missed the fence flush. > > Signed-off-by: Chris Wilson Actually no, this set_to_gtt is actually just a flush+wait_rendering because the shmem pwrite/pread afters does clever in-line clflushing. Abuse of interfaces, I know ... -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48