From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: don't clobber the special
 upscaling lvds timings
Date: Mon, 16 Apr 2012 09:34:44 +0200
Message-ID: <20120416073423.GA4199@phenom.ffwll.local>
References: <1334511498_2671@CP5-2952>
	<1334512399-15887-1-git-send-email-daniel.vetter@ffwll.ch>
	<1334513013_2817@CP5-2952>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-we0-f177.google.com (mail-we0-f177.google.com
	[74.125.82.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id 8AB179E7B5
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 16 Apr 2012 00:33:53 -0700 (PDT)
Received: by werp11 with SMTP id p11so3816045wer.36
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 16 Apr 2012 00:33:52 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1334513013_2817@CP5-2952>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Sun, Apr 15, 2012 at 07:03:18PM +0100, Chris Wilson wrote:
> On Sun, 15 Apr 2012 19:53:19 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > This regression has been introduced in
> > 
> > commit ca9bfa7eed20ea34e862804e62aae10eb159edbb
> > Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Date:   Sat Jan 28 14:49:20 2012 +0100
> > 
> >     drm/i915: fixup interlaced vertical timings confusion, part 1
> > 
> > Unfortunately that commit failed to take into account that the lvds
> > code does some special adjustements to the crtc timings for upscaling
> > an centering.
> > 
> > Fix this by explicitly computing crtc timings in the lvds mode fixup
> > function and setting a special flag in mode->private_flags if the crtc
> > timings have been adjusted.
> > 
> > v2: Add a comment to explain the new mode driver private flag,
> > suggested by Eugeni Dodonov.
> > 
> > v3: Kill the confusing and now redundant set_crtcinfo call in
> > intel_fixed_panel_mode, noticed by Chris Wilson.
> > 
> > Reported-and-Tested-by: Hans de Bruin <jmdebruin@xmsnet.nl>
> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=43071
> > Reviewed-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
> > Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> The patch fixes a regression and shouldn't have any side-effects as far
> as I can see, so
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> 
> Just wish there were more ponies.

Picked up for -fixes, thanks for the review.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48