From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH] drm/i915/sprite: Always enable the scaler on IronLake Date: Mon, 16 Apr 2012 08:54:17 -0700 Message-ID: <20120416085417.3b652e43@jbarnes-desktop> References: <1334438066-11482-1-git-send-email-chris@chris-wilson.co.uk> <20120416080017.30ceb7b2@jbarnes-desktop> <1334589278_8242@CP5-2952> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy6-pub.bluehost.com (oproxy6-pub.bluehost.com [67.222.54.6]) by gabe.freedesktop.org (Postfix) with SMTP id 8E8499E8B8 for ; Mon, 16 Apr 2012 08:54:23 -0700 (PDT) In-Reply-To: <1334589278_8242@CP5-2952> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 16 Apr 2012 16:14:25 +0100 Chris Wilson wrote: > On Mon, 16 Apr 2012 08:00:17 -0700, Jesse Barnes wrote: > > Funky... do you notice any difference in output (fuzziness or anything) > > with the scaler enabled? Wonder if it's safe to enable for 1:1 scaling > > on SNB as well. > > Hard to tell. Without the scaler being enabled, it is black. :) Oh I misread "doesn't update" as "you only see the first frame". I guess we can compare on SNB at least and potentially enable the scaler all the time. > The content I was using was regular compressed mpeg-ts, so not the best > for juding aesthetic quality. We'd have to render some test geometry, > such as testdisplay to be sure. (testplanes? ;) There's a sprite_on test in there somewhere, but a new testplanes wouldn't hurt. > The docs do suggest that we disable the scaler to save power, so > probably best if we keep the code as is. Ok, sounds good. -- Jesse Barnes, Intel Open Source Technology Center