From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH] drm/i915: intel_update_fbc() requires struct_mutex, so no longer atomic Date: Tue, 17 Apr 2012 08:49:06 -0700 Message-ID: <20120417084906.7de696f0@jbarnes-desktop> References: <1334671699-11631-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy6-pub.bluehost.com (oproxy6-pub.bluehost.com [67.222.54.6]) by gabe.freedesktop.org (Postfix) with SMTP id 9763C9E835 for ; Tue, 17 Apr 2012 08:49:10 -0700 (PDT) In-Reply-To: <1334671699-11631-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 17 Apr 2012 15:08:19 +0100 Chris Wilson wrote: > As we need to manipulate our device structure and allocate queue a task, > it is no longer a simple atomic operation and cannot be performed along > the atomic modeset paths. Instead make sure that we disable FBC (which > must be therefore kept as a set of simple register writes) when > performing the atomic modeset and leave the heavy-weight > intel_update_fbc() for the normal modeset. > > Signed-off-by: Chris Wilson > Cc: Jesse Barnes > --- Looks good. Reviewed-by: Jesse Barnes