From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 0/5] refactor power management into intel_pm
Date: Tue, 17 Apr 2012 12:23:43 +0200
Message-ID: <20120417102343.GI4104@phenom.ffwll.local>
References: <1334625638-11971-1-git-send-email-eugeni.dodonov@intel.com>
	<20120417085717.GA4104@phenom.ffwll.local>
	<CAC7LmnuPkOHE_t0G4trKaJeKrtnKqohC+kwqO_MyKfz2SH8EZw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49])
	by gabe.freedesktop.org (Postfix) with ESMTP id 77BFCA02AA
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 17 Apr 2012 03:22:48 -0700 (PDT)
Received: by eekb45 with SMTP id b45so1560912eek.36
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 17 Apr 2012 03:22:47 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CAC7LmnuPkOHE_t0G4trKaJeKrtnKqohC+kwqO_MyKfz2SH8EZw@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Eugeni Dodonov <eugeni@dodonov.net>
Cc: intel-gfx@lists.freedesktop.org, Eugeni Dodonov <eugeni.dodonov@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Apr 17, 2012 at 06:56:27AM -0300, Eugeni Dodonov wrote:
> On Tue, Apr 17, 2012 at 05:57, Daniel Vetter <daniel@ffwll.ch> wrote:
> 
> > On Mon, Apr 16, 2012 at 10:20:33PM -0300, Eugeni Dodonov wrote:
> > > As Chris Wilson noticed, my previous patch that did the refactoring as
> > one big
> > > patch which moved everything at once was extremely difficult to review
> > and
> > > maintain. So I split the same refactoring into a series of smaller
> > patches,
> > > which move one subsystem at a time.
> >
> > Yeah, diffs are not actually readable, so looks like we have to do this
> > piece-wise.
> 
> 
> Please, tell me that you meant 'diffs are *now* actually readable' with a
> 'not' being a typo instead of 'now' there by a chance...
> 
> Because otherwise I couldn't understand what you meant with piece-wise.
> Should I move each function at a time? :)

Meh, type, diffs are _now_ readable ;-)

> I'll do the intel_pm_init (or intel_init_pm) and send it on top of this
> series. It makes lots of sense and will avoid exposing all those
> platform-specific stuff where we won't need it except for initialization.

Cool, I'll review the entire series in context of that additional patch
then.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48