From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 5/5] drm/i915: Always flush tiling changes before accessing through the GTT Date: Wed, 18 Apr 2012 10:48:53 +0200 Message-ID: <20120418084853.GD5315@phenom.ffwll.local> References: <1334393751-8921-1-git-send-email-chris@chris-wilson.co.uk> <1334393751-8921-5-git-send-email-chris@chris-wilson.co.uk> <20120414220035.GD4215@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ey0-f177.google.com (mail-ey0-f177.google.com [209.85.215.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 45BA7A0AD8 for ; Wed, 18 Apr 2012 01:47:56 -0700 (PDT) Received: by eaak13 with SMTP id k13so1823517eaa.36 for ; Wed, 18 Apr 2012 01:47:55 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20120414220035.GD4215@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Sun, Apr 15, 2012 at 12:00:35AM +0200, Daniel Vetter wrote: > On Sat, Apr 14, 2012 at 09:55:51AM +0100, Chris Wilson wrote: > > As we defer updating the fence register from set-tiling to the point of > > use, we need to declare every access through the GTT as either fenced or > > unfenced. > > > > This patches fixes an old bug in the execbuffer relocation processing > > which could conceivably be hit by a pathological userspace. > > > > Signed-off-by: Chris Wilson > Indeed, my git history digging got lost and given how we upload buffers I > don't think there's any chance we can hit this, so no i-g-t test > necessary. > Reviewed-by: Daniel Vetter Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48