Re: [PATCH 5/5] drm/i915: Always flush tiling changes before accessing through the GTT

Daniel Vetter
2012-04-18T08:47:56Z

On Sun, Apr 15, 2012 at 12:00:35AM +0200, Daniel Vetter wrote:
> On Sat, Apr 14, 2012 at 09:55:51AM +0100, Chris Wilson wrote:
> > As we defer updating the fence register from set-tiling to the point of
> > use, we need to declare every access through the GTT as either fenced or
> > unfenced.
> >
> > This patches fixes an old bug in the execbuffer relocation processing
> > which could conceivably be hit by a pathological userspace.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Indeed, my git history digging got lost and given how we upload buffers I
> don't think there's any chance we can hit this, so no i-g-t test
> necessary.
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48