Re: [PATCH 4/5] drm/i915: Always flush tiling changes before accessing through the GTT

Daniel Vetter
2012-04-14T21:53:57Z

On Sat, Apr 14, 2012 at 09:55:50AM +0100, Chris Wilson wrote:
> As we defer updating the fence register from set-tiling to the point of
> use, we need to declare every access through the GTT as either fenced or
> unfenced.
>
> This patches fixes up a couple of freshly introduced GTT accesses which
> missed the fence flush.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Actually no, this set_to_gtt is actually just a flush+wait_rendering
because the shmem pwrite/pread afters does clever in-line clflushing.
Abuse of interfaces, I know ...
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48