Re: [PATCH 1/5] drm/i915: Suppress EIO during set-to-gtt

Chris Wilson
2012-04-18T09:10:45Z

On Wed, 18 Apr 2012 11:03:03 +0200, Daniel Vetter <daniel@ffwll.ch> wrote:
> Now given how well-tested that code is, I expect bugs. But imo the right
> course of action is to make that code testable first before we sprinkle
> -EIO handling all over the place. I've planned to resurrect my gpu hangman
> this week, and I'm thinking of ways to extend that to test our -EIO/gpu
> wedging code.

I disagree with this approach. I need the driver to robust its own
failures so that we don't lose data. I know from experience that is
currently not.

Looking at the code paths required for CPU access and making them
resilient as possible is a necessary evil, imho.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre