From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Replace open coded MI_BATCH_GTT Date: Wed, 18 Apr 2012 11:11:32 +0200 Message-ID: <20120418091132.GH5315@phenom.ffwll.local> References: <1334677092-13374-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ey0-f177.google.com (mail-ey0-f177.google.com [209.85.215.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 0EA99A0AFE for ; Wed, 18 Apr 2012 02:10:34 -0700 (PDT) Received: by eaak13 with SMTP id k13so1829803eaa.36 for ; Wed, 18 Apr 2012 02:10:34 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1334677092-13374-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Apr 17, 2012 at 04:38:12PM +0100, Chris Wilson wrote: > The (2<<6) virtual memory space selector harks back to gen3 and is > mandatory given our use of GTT space for batchbuffers. On gen4+, use of > the GTT became mandatory and bit6 marked reserved. However the code must > now explicitly set (1<<7), which conveniently is also (2<<6). > > To clarify the meaning for future readers, replace the open coded (2<<6) > with MI_BATCH_GTT. > > Signed-off-by: Chris Wilson Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48