From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: intel_update_fbc() requires struct_mutex, so no longer atomic Date: Wed, 18 Apr 2012 12:02:18 +0200 Message-ID: <20120418100218.GM5315@phenom.ffwll.local> References: <1334671699-11631-1-git-send-email-chris@chris-wilson.co.uk> <20120417084906.7de696f0@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by gabe.freedesktop.org (Postfix) with ESMTP id B7D719E74C for ; Wed, 18 Apr 2012 03:01:21 -0700 (PDT) Received: by eekb45 with SMTP id b45so1862924eek.36 for ; Wed, 18 Apr 2012 03:01:20 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20120417084906.7de696f0@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Apr 17, 2012 at 08:49:06AM -0700, Jesse Barnes wrote: > On Tue, 17 Apr 2012 15:08:19 +0100 > Chris Wilson wrote: > > > As we need to manipulate our device structure and allocate queue a task, > > it is no longer a simple atomic operation and cannot be performed along > > the atomic modeset paths. Instead make sure that we disable FBC (which > > must be therefore kept as a set of simple register writes) when > > performing the atomic modeset and leave the heavy-weight > > intel_update_fbc() for the normal modeset. > > > > Signed-off-by: Chris Wilson > > Cc: Jesse Barnes > > --- > > Looks good. > > Reviewed-by: Jesse Barnes Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48