From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Don't set a MBZ bit in gen2/3 MI_FLUSH Date: Wed, 18 Apr 2012 12:40:37 +0200 Message-ID: <20120418104037.GN5315@phenom.ffwll.local> References: <20120418094104.GL5315@phenom.ffwll.local> <1334743931-31100-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ey0-f177.google.com (mail-ey0-f177.google.com [209.85.215.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 9A8CE9E74C for ; Wed, 18 Apr 2012 03:39:40 -0700 (PDT) Received: by eaak13 with SMTP id k13so1855332eaa.36 for ; Wed, 18 Apr 2012 03:39:39 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1334743931-31100-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Apr 18, 2012 at 11:12:11AM +0100, Chris Wilson wrote: > On gen2 MI_EXE_FLUSH is actually an AGP flush bit and on gen3 marked as > reserved. On both it is documented as being must-be-zero. So obey the > documentation, and separate the gen2 flush into its own little routine > and share with gen3. > > This means that we can rename the existing render_ring_flush() to > reflect the generation from which it first applies and remove the code > for handling earlier generations from it. > > v2: Applies to gen3 as well > v3: Make it compile and improve the commit message. > > Signed-off-by: Chris Wilson Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48