From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Wait for all pending operations to the fb before disabling the pipe Date: Wed, 18 Apr 2012 13:01:51 +0200 Message-ID: <20120418110151.GO5315@phenom.ffwll.local> References: <1334653538-14646-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ey0-f177.google.com (mail-ey0-f177.google.com [209.85.215.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 426D89E796 for ; Wed, 18 Apr 2012 04:00:57 -0700 (PDT) Received: by eaak13 with SMTP id k13so1861453eaa.36 for ; Wed, 18 Apr 2012 04:00:56 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1334653538-14646-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Apr 17, 2012 at 10:05:38AM +0100, Chris Wilson wrote: > During modeset we have to disable the pipe to reconfigure its timings > and maybe its size. Userspace may have queued up command buffers that > depend upon the pipe running in a certain configuration and so the > commands may become confused across the modeset. At the moment, we use a > less than satisfactory kick-scanline-waits should the GPU hang during > the modeset. It should be more reliable to wait for the pending > operations to complete first, even though we still have a window for > userspace to submit a broken command buffer during the modeset. > > Signed-off-by: Chris Wilson Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48