From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: rc6 residency (fix the fix)
Date: Fri, 20 Apr 2012 21:27:53 +0200
Message-ID: <20120420192753.GI4217@phenom.ffwll.local>
References: <1334947801-17280-1-git-send-email-ben@bwidawsk.net>
	<1334949869_7667@CP5-2952>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43])
	by gabe.freedesktop.org (Postfix) with ESMTP id CCDD49E73D
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 20 Apr 2012 12:26:55 -0700 (PDT)
Received: by wgbdr12 with SMTP id dr12so8018011wgb.12
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 20 Apr 2012 12:26:55 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1334949869_7667@CP5-2952>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ben Widawsky <ben@bwidawsk.net>, intel-gfx@lists.freedesktop.org, Ben Widawsky <benjamin.widawsky@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Apr 20, 2012 at 08:24:04PM +0100, Chris Wilson wrote:
> On Fri, 20 Apr 2012 11:50:01 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> > Chris' fix for my 32b breakage was incorrect. do_div returns a
> > remainder. Go back to a divide macro which is more 32b friendly.
> > 
> > Tested on x86-64.
> > 
> > This has only been compile tested on 32b systems.
> > 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=48756
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Ben Widawsky <benjamin.widawsky@intel.com>
> Sincere-apologies: Chris Wilson <chris@chris-wilson.co.uk>
> 
> Had I looked for the equivalent 64bit DIV_ROUND_UP, I could have saved
> myself some embarrassment.
Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48