Re: [PATCH 04/10] drm/i915: drop polled waits from i915_wait_request

Ben Widawsky
2012-04-21T16:15:43Z

On Sat, 21 Apr 2012 10:29:35 +0100
Chris Wilson <chris@chris-wilson.co.uk> wrote:

> On Fri, 20 Apr 2012 18:23:26 -0700, Ben Widawsky <ben@bwidawsk.net>
> wrote:
> > The only time irq_get should fail is during unload or suspend. Both
> > of these points should try to quiesce the GPU before disabling
> > interrupts and so the atomic polling should never occur.
> >
> > This was recommended by Chris Wilson as a way of reducing added
> > complexity to the polled wait which I introduced in an RFC patch.
> >
> > 09:57 < ickle_> it's only there as a fudge for waiting after irqs
> > after uninstalled during s&r, we aren't actually meant to hit it
> > 09:57 < ickle_> so maybe we should just kill the code there and fix
> > the breakage
> >
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Ben Widawsky <benjamin.widawsky@intel.com>
> > ---
>
> > + if (WARN_ON(!ring->irq_get(ring)))
> > + return -EBUSY;
>
> I think this is now a -ENODEV; :)
> -Chris
>
Got it. Thanks.