From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915/sprite: Avoid incurring extra vblank stall when updating plane on IVB Date: Sat, 21 Apr 2012 18:53:55 +0200 Message-ID: <20120421165355.GG5019@phenom.ffwll.local> References: <1334765546-733-1-git-send-email-chris@chris-wilson.co.uk> <20120418092346.46cd7d4d@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id C652A9E9E0 for ; Sat, 21 Apr 2012 09:52:56 -0700 (PDT) Received: by wgbdr12 with SMTP id dr12so8518810wgb.12 for ; Sat, 21 Apr 2012 09:52:56 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20120418092346.46cd7d4d@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Apr 18, 2012 at 09:23:46AM -0700, Jesse Barnes wrote: > On Wed, 18 Apr 2012 17:12:26 +0100 > Chris Wilson wrote: > > > IvyBridge requires an extra frame between disabling the low power > > watermarks and enabling scaling on the sprite plane. If the scaling > > is already enabled, then we have already disabled the low power > > watermarks and need not incur an extra wait. > > > > Similarly, as we disable the scaling when turning off the sprite plane, > > we can update the scaling enabled flag and restore the low power > > watermarks. > > > > Signed-off-by: Chris Wilson > > Cc: Jesse Barnes > > --- > > Yep, this is a good optimization. > > Reviewed-by: Jesse Barnes Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48