From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 03/10] drm/i915: kill waiting_seqno
Date: Sun, 22 Apr 2012 10:47:57 -0700
Message-ID: <20120422104757.4db9623a@bwidawsk.net>
References: <1334971412-4826-1-git-send-email-ben@bwidawsk.net>
	<1334971412-4826-4-git-send-email-ben@bwidawsk.net>
	<1335102395_20078@CP5-2952>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com
	[184.106.247.128])
	by gabe.freedesktop.org (Postfix) with ESMTP id 170159E9F7
	for <intel-gfx@lists.freedesktop.org>;
	Sun, 22 Apr 2012 10:49:24 -0700 (PDT)
In-Reply-To: <1335102395_20078@CP5-2952>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Sun, 22 Apr 2012 14:46:05 +0100
Chris Wilson <chris@chris-wilson.co.uk> wrote:

> On Fri, 20 Apr 2012 18:23:25 -0700, Ben Widawsky <ben@bwidawsk.net>
> wrote:
> > diff --git a/drivers/gpu/drm/i915/i915_irq.c
> > b/drivers/gpu/drm/i915/i915_irq.c index cf0e9f0..52eb9ed 100644
> > --- a/drivers/gpu/drm/i915/i915_irq.c
> > +++ b/drivers/gpu/drm/i915/i915_irq.c
> > @@ -1846,11 +1846,9 @@ static bool i915_hangcheck_ring_idle(struct
> > intel_ring_buffer *ring, bool *err)
> 
> So ring->waiting_seqno was also in effect checking that the ring was
> initialised here. Inappropriately, I might add.
> 
> Anyway we need:
> 
>   if (ring->obj == NULL)
> 	return true;
> 
> >  	if (list_empty(&ring->request_list) ||
> >  	    i915_seqno_passed(ring->get_seqno(ring),
> > ring_last_seqno(ring))) { /* Issue a wake-up to catch stuck h/w. */
> > -		if (ring->waiting_seqno &&
> > waitqueue_active(&ring->irq_queue)) {
> > -			DRM_ERROR("Hangcheck timer elapsed... %s
> > idle [waiting on %d, at %d], missed IRQ?\n",
> > -				  ring->name,
> > -				  ring->waiting_seqno,
> > -				  ring->get_seqno(ring));
> > +		if (waitqueue_active(&ring->irq_queue)) {
> > +			DRM_ERROR("Hangcheck timer elapsed... %s
> > idle\n",
> > +				  ring->name);
> >  			wake_up_all(&ring->irq_queue);
> >  			*err = true;
> >  		}
> 

Got it. Thanks.