From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/2] drm/i915: Only the zap the VMA after updating the tiling parameters Date: Sun, 22 Apr 2012 14:53:42 +0200 Message-ID: <20120422125342.GG4723@phenom.ffwll.local> References: <1335021804-31847-1-git-send-email-chris@chris-wilson.co.uk> <1335021804-31847-2-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 55C039E7B2 for ; Sun, 22 Apr 2012 05:52:43 -0700 (PDT) Received: by werp11 with SMTP id p11so8556940wer.36 for ; Sun, 22 Apr 2012 05:52:42 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1335021804-31847-2-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Sat, Apr 21, 2012 at 04:23:24PM +0100, Chris Wilson wrote: > If we fail to unbind and so abort the change in tiling, we will have > removed the VMA for the object for no reason. The likelihood of unbind > failing is slim (other than ERESTARTSYS which will cause userspace to > try again), so the change is mostly for the principle. > > Also improve the slightly stale comment. > > Signed-off-by: Chris Wilson Queued both for -next (with some bikeshed on the commit message for the first patch), thanks for the patches. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48