Re: [PATCH] properly enable the blc controller on the right pipe

Daniel Vetter
2012-06-02T23:06:37Z

On Fri, Apr 27, 2012 at 10:18:08PM +0200, Carsten Emde wrote:
> Daniel,
>
> >>>Depending upon how things are set up, this might help.
> >>Yeah, thanks a lot, works great now!
> >>I removed patch 3/4 and 4/4 and pushed this one; so currently applied are:
> >>[PATCH 1/4] drm/i915: clear up backlight inversion confusion on gen4
> >>[PATCH 2/4] drm/i915: completely revert the invert brightness quirk
> >>[PATCH] properly enable the blc controller on the right pipe
> >Hey, that was just a quick hack to check things ;-)
> Sorry, too many things in parallel.
>
> Spent some time reading the docs you mentioned - will continue to
> work on the backlight brightness problem and prepare another patch.
> I just need some more time.

Ok, I've stitched together some real patches and actually tested them.
While doing so I've noticed that the patch you've tested essentially
disables the i915 backlight control and leaves everything to the legacy or
platform backlight control.

New patches are at

http://cgit.freedesktop.org/~danvet/drm/log/?h=backlight-confusion

Note that these do not include the revert for the backlight inversion
quirk. You either have to revert that yourself for testing or disable the
backlight inversion on the kernel bootline.

Testing feedback highly welcome.

Yours, Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48