Re: [PATCH 10/22] drm/i915: remove LP_RING&friends from modeset code

Chris Wilson
2012-04-23T22:36:59Z

On Mon, 23 Apr 2012 16:50:57 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> The LP refers to 'low priority' as opposed to the high priority
> ring on gen2/3. So lets constrain its use to the code of that era.
>
> Unfortunately we can't yet completely remove the associated
> macros from common headers and shove them into i915_dma.c to
> the other dri1 legacy support code, a few cleanups are still
> missing for that.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

I'll on many occasions wished that the driver stopped shouting and
consistently used intel_ring*, so
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

--
Chris Wilson, Intel Open Source Technology Centre