From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 1/6] drm/i915: Unconditionally initialise the interrupt workers Date: Tue, 24 Apr 2012 12:12:36 -0700 Message-ID: <20120424121236.68196e3e@jbarnes-desktop> References: <1335288691-21819-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy5-pub.bluehost.com (oproxy5-pub.bluehost.com [67.222.38.55]) by gabe.freedesktop.org (Postfix) with SMTP id 3D0CF9ED03 for ; Tue, 24 Apr 2012 12:12:39 -0700 (PDT) In-Reply-To: <1335288691-21819-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 24 Apr 2012 18:31:26 +0100 Chris Wilson wrote: > Rather than duplicate similar code across the IRQ installers, perform > the initialisation of the workers upfront. This will lead to simpler > teardown and quiescent code as we can assume that the workers have > been initialised. > > Signed-off-by: Chris Wilson > --- Looks nice, and also gives me warm fuzzies about the potential races between setting up the work queues and interrupts arriving since it would be all too easy to accidentally call these in postinstall on some new hw platform. Reviewed-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center